Renaming node to provider & adding tests#93
Closed
marcosfrenkel wants to merge 3 commits into
Closed
Conversation
marcosfrenkel
force-pushed
the
renaming_node
branch
2 times, most recently
from
5414007 to
f5c1837
Compare
marcosfrenkel
force-pushed
the
renaming_node
branch
from
f5c1837 to
0a2f755
Compare
Collaborator
Author
|
More testing is needed. Closing for private testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have renamed every mention of the old
NodeintoInstrumentProviderorproviderwhen appropriate.New pytests have been added to test the basic behavior of them as well. To test them simply run pytest in the root of the project:
uv run pytest